fix: harden the install / update / uninstall scripts
Nightly Build / build (push) Successful in 7m50s

Four things found while re-reading the family of scripts around the
logout fix.

Both installers piped curl straight into tar, so a truncated download
half-extracted — and the installer explicitly supports reinstalling over
an existing install, which turned an interrupted download into a tree
mixing old and new files with no error saying so. They now download to a
temp file and verify the archive in a staging dir before writing
anything to the install directory: the ordering update.sh has had since
it was written, for the same reason.

update.sh never removed files deleted upstream. Extracting over the
install dir only adds and overwrites, so a renamed page under docs/ kept
being mounted read-only into every container for the assistant to read,
and a removed command kept being discovered. It now prunes, from the
directories the tarball owns end to end (web, commands, skills, docs),
whatever the already-verified staging copy does not have. Pruning after
the extraction rather than replacing the directory keeps every
intermediate state a complete install. agents/ is deliberately excluded:
dropping in an agent is a documented extension point, so that directory
is not ours alone and pruning it would delete somebody's work.

uninstall.sh fed `docker ps -aq --filter 'name=skald-'` to `docker rm
-f`. Docker's name filter is a regex matched anywhere in the name, not a
prefix, so any unrelated container merely containing "skald-" was
force-removed. Anchored to ^skald-.

uninstall.sh also matched uname's raw Linux/Darwin while its three
siblings normalize to lowercase. It was correct on its own, but being
the odd one out of four copy-paste relatives is precisely how update.sh
acquired its no-op case arms, so it now normalizes like the others.

Finally, the uninstaller reports that lingering is still enabled and how
to turn it off, rather than disabling it: it is a persistent per-user
setting other user services may rely on by now, so taking it back
silently would stop those too.
This commit is contained in:
2026-08-06 13:19:57 +01:00
parent bb5226a9a9
commit 6d69d3057a
5 changed files with 131 additions and 10 deletions
+22 -2
View File
@@ -343,12 +343,32 @@ if [ -x "$INSTALL_DIR/bin/skald" ]; then
fi
# ── Download & extract ────────────────────────────────────────────────────────
# Download to a temp file and verify the archive BEFORE touching the install dir
# — the same ordering update.sh uses, and for the same reason. Piping curl
# straight into tar half-extracts a truncated download, which on the
# reinstall-over-an-existing-install path above leaves a tree mixing old and new
# files: worse than either version, and with no error to say so.
info "↓ Downloading Skald Circle ${VERSION}"
TMP_TARBALL="$(mktemp -t skald-install.XXXXXX.tar.gz)"
STAGING="$(mktemp -d -t skald-install-staging.XXXXXX)"
trap 'rm -f "$TMP_TARBALL" 2>/dev/null || true; rm -rf "$STAGING" 2>/dev/null || true' EXIT
curl -fsSL -o "$TMP_TARBALL" "$TARBALL_URL"
info "🔎 Verifying archive …"
tar xzf "$TMP_TARBALL" -C "$STAGING" --strip-components=1
if [ ! -x "$STAGING/bin/skald" ]; then
err "Downloaded archive is invalid — skald binary not found."
err "Nothing was written to ${INSTALL_DIR}."
exit 1
fi
mkdir -p "$INSTALL_DIR"
curl -fsSL "$TARBALL_URL" | tar xz -C "$INSTALL_DIR" --strip-components=1
tar xzf "$TMP_TARBALL" -C "$INSTALL_DIR" --strip-components=1
if [ ! -x "$INSTALL_DIR/bin/skald" ]; then
err "Download or extraction failed — skald binary not found."
err "Extraction failed — skald binary not found."
exit 1
fi