Files
dguiducci 6d299472e3 feat(mcp): Connectors — catalog + global vs per-user runtimes (§7/§14/§15)
Re-architects MCP from one owner table + agent-written registration into an
admin-curated catalog with two runtimes unioned per session, surfaced in the UI
as "Connectors" (mcp/schema stays neutral, §0.1).

Two runtimes behind one seam (§7):
- Global runtime: shared, stateless connectors (web-search, Tavily…) on the
  HOST, connected at boot from mcp_global_servers, access-filtered per user via
  mcp_global_access.
- Per-user runtime: a user's activated connectors run INSIDE their container,
  started at first login from mcp_user_servers and living until restart (§9);
  docker exec -i children die via kill_on_drop when the UserContext drops.
- McpProvider trait (mcp/provider.rs): the session round-loop never learns which
  runtime owns a server. McpManager implements it directly (inert ownerless
  bundle); UserMcpView implements global ∪ user with an accessible_global
  snapshot. Both share McpManager::connect_all; McpServerSpec +
  global_row_spec/user_row_spec turn a DB row into a connectable spec.
- mcp-client: McpServerConfig.launch_in runs a stdio command inside a container
  via docker exec -i (set at runtime, never parsed from config).

Authorization is a capability on the role, not `if role==admin` (§0.1/§14):
role_capabilities table + db/role_capabilities.rs — register_remote and
register_local_from_catalog are self-service (seeded on every new role), while
register_local_script and manage_catalog are admin-only. admin holds every
capability by construction. This removes the agent-facing register_mcp/delete_mcp
tools and the mcp kinds of list_items/toggle_item, closing the §14 RCE vector.

Schema:
- Registry: mcp_catalog (vetted templates — schema only, no live creds),
  mcp_global_servers + mcp_global_access, role_capabilities.
- Owner: mcp_user_servers (per-user activations; api_key encrypted at rest,
  catalog_name a bare TEXT snapshot, never an owner→registry FK).
- Drops the old owner table mcp_servers.

API + UI: src/frontend/api/mcp.rs (admin catalog/global/access + user
available/activate/activated, all capability-gated via require_cap);
web/components/connectors.js (<connectors-page>) renders the user view always
and the admin view for role_id === 'admin'.

Deferred: interactive per-user auth (OAuth callback / QR / SSH elicitation, §15)
— only none/api_key wired; no boot seed of catalog presets; per-(user, session)
MCP grant model still open.
2026-07-16 16:44:12 +01:00

105 lines
3.5 KiB
Rust

//! End-to-end test of `tools/list` cursor pagination against a real stdio MCP
//! subprocess.
//!
//! A tiny Python "server" returns its tools across two pages: the first
//! `tools/list` (no `cursor`) yields one tool plus a `nextCursor`; the follow-up
//! (with that `cursor`) yields the rest and no `nextCursor`. This exercises the
//! cursor loop in `McpServer::start`. Skipped if `python3` is absent.
use std::io::Write;
use std::process::Command;
use mcp_client::config::{McpServerConfig, McpTransport};
use mcp_client::server::McpServer;
const FAKE_SERVER: &str = r#"
import sys, json
def send(obj):
sys.stdout.write(json.dumps(obj) + "\n")
sys.stdout.flush()
def readline():
line = sys.stdin.readline()
if not line:
return None
line = line.strip()
return line if line else readline()
while True:
raw = readline()
if raw is None:
break
msg = json.loads(raw)
mid = msg.get("id")
method = msg.get("method")
if method == "initialize":
send({"jsonrpc": "2.0", "id": mid, "result": {
"protocolVersion": "2025-11-25", "capabilities": {},
"serverInfo": {"name": "fake", "version": "0"}}})
elif method == "notifications/initialized":
pass
elif method == "tools/list":
cursor = (msg.get("params") or {}).get("cursor")
if cursor is None:
# Page 1: one tool + a cursor pointing at the next page.
send({"jsonrpc": "2.0", "id": mid, "result": {
"tools": [{"name": "alpha", "description": "first",
"inputSchema": {"type": "object", "properties": {}}}],
"nextCursor": "page-2"}})
elif cursor == "page-2":
# Page 2: the rest, no further cursor → loop terminates.
send({"jsonrpc": "2.0", "id": mid, "result": {
"tools": [{"name": "beta", "description": "second",
"inputSchema": {"type": "object", "properties": {}}},
{"name": "gamma", "description": "third",
"inputSchema": {"type": "object", "properties": {}}}]}})
else:
send({"jsonrpc": "2.0", "id": mid, "result": {"tools": []}})
elif mid is not None:
send({"jsonrpc": "2.0", "id": mid, "error": {"code": -32601, "message": "unknown"}})
"#;
fn python3_available() -> bool {
Command::new("python3").arg("--version").output().is_ok()
}
#[tokio::test]
async fn tools_list_follows_next_cursor_across_pages() {
if !python3_available() {
eprintln!("python3 not found — skipping pagination integration test");
return;
}
let script_path =
std::env::temp_dir().join(format!("skald_paginate_{}.py", std::process::id()));
std::fs::File::create(&script_path)
.unwrap()
.write_all(FAKE_SERVER.as_bytes())
.unwrap();
let cfg = McpServerConfig {
name: "fake".to_string(),
transport: McpTransport::Stdio,
command: Some("python3".to_string()),
args: Some(vec![script_path.to_string_lossy().to_string()]),
env: None,
url: None,
api_key: None,
launch_in: None,
};
let server = McpServer::start(&cfg, None, None, None)
.await
.expect("server should start");
let names: Vec<&str> = server.tools().iter().map(|t| t.name.as_str()).collect();
assert_eq!(
names,
vec!["alpha", "beta", "gamma"],
"all pages should be collected"
);
let _ = std::fs::remove_file(&script_path);
}